Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for trigger function #1610

Closed
wants to merge 6 commits into from
Closed

Fix for trigger function #1610

wants to merge 6 commits into from

Conversation

hkoley
Copy link
Contributor

@hkoley hkoley commented Apr 26, 2024

No description provided.

@github-actions GitHub Actions
Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2022-pp-apass4
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2022-pp-apass6-2023-PbPb-apass2
async-2022-pp-apass4-accepted
async-2022-pp-apass6-2023-PbPb-apass2-accepted
async-2023-pbpb-apass3-accepted
async-2023-pbpb-apass4-accepted

BongHwi
BongHwi reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@BongHwi BongHwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @hkoley for the update on the triggered production script.

Here are some suggestions.

Have you tried to run this on the grid?

MC/config/PWGLF/ini/GeneratorLF_Resonances_PbPb5360_trigger.ini Outdated
@@ -1,10 +1,10 @@
[GeneratorExternal]
fileName=${O2DPG_ROOT}/MC/config/PWGLF/pythia8/generator_pythia8_LF.C
funcName=generateLF("${O2DPG_ROOT}/MC/config/PWGLF/pythia8/generator/resonancelistgun_trig_pbpb.json", true, 4)
funcName=generateLFTriggered("${O2DPG_ROOT}/MC/config/PWGLF/pythia8/generator/resonancelistgun_trig_pbpb.json", true, 4)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
funcName=generateLFTriggered("${O2DPG_ROOT}/MC/config/PWGLF/pythia8/generator/resonancelistgun_trig_pbpb.json", true, 4)
funcName=generateLFTriggered("${O2DPG_ROOT}/MC/config/PWGLF/pythia8/generator/resonancelistgun_trig_pbpb.json", 4)

MC/config/PWGLF/ini/GeneratorLF_Resonances_PbPb5360_trigger.ini
config[1]=${O2DPG_ROOT}/MC/config/PWGLF/pythia8/generator/resonances.cfg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
config[1]=${O2DPG_ROOT}/MC/config/PWGLF/pythia8/generator/resonances.cfg
config[1]=${O2DPG_ROOT}/MC/config/PWGLF/pythia8/generator/resonances.cfg

MC/config/PWGLF/ini/GeneratorLF_Resonances_pp1360_trigger.ini Outdated
@@ -1,10 +1,10 @@
[GeneratorExternal]
fileName=${O2DPG_ROOT}/MC/config/PWGLF/pythia8/generator_pythia8_LF.C
funcName=generateLF("${O2DPG_ROOT}/MC/config/PWGLF/pythia8/generator/resonancelistgun_trig.json", true, 4)
funcName=generateLFTriggered("${O2DPG_ROOT}/MC/config/PWGLF/pythia8/generator/resonancelistgun_trig.json", true, 4)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
funcName=generateLFTriggered("${O2DPG_ROOT}/MC/config/PWGLF/pythia8/generator/resonancelistgun_trig.json", true, 4)
funcName=generateLFTriggered("${O2DPG_ROOT}/MC/config/PWGLF/pythia8/generator/resonancelistgun_trig.json", 4)

MC/config/PWGLF/ini/GeneratorLF_Resonances_pp1360_trigger.ini
config[1]=${O2DPG_ROOT}/MC/config/PWGLF/pythia8/generator/resonances.cfg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
config[1]=${O2DPG_ROOT}/MC/config/PWGLF/pythia8/generator/resonances.cfg
config[1]=${O2DPG_ROOT}/MC/config/PWGLF/pythia8/generator/resonances.cfg

MC/config/PWGLF/ini/GeneratorLF_Resonances_pp900_trigger.ini Outdated
@@ -1,10 +1,10 @@
[GeneratorExternal]
fileName=${O2DPG_ROOT}/MC/config/PWGLF/pythia8/generator_pythia8_LF.C
funcName=generateLF("${O2DPG_ROOT}/MC/config/PWGLF/pythia8/generator/resonancelistgun_trig.json", true, 4)
funcName=generateLFTriggered("${O2DPG_ROOT}/MC/config/PWGLF/pythia8/generator/resonancelistgun_trig.json", true, 4)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
funcName=generateLFTriggered("${O2DPG_ROOT}/MC/config/PWGLF/pythia8/generator/resonancelistgun_trig.json", true, 4)
funcName=generateLFTriggered("${O2DPG_ROOT}/MC/config/PWGLF/pythia8/generator/resonancelistgun_trig.json", 4)

MC/config/PWGLF/ini/GeneratorLF_Resonances_pp900_trigger.ini
config[1]=${O2DPG_ROOT}/MC/config/PWGLF/pythia8/generator/resonances.cfg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
config[1]=${O2DPG_ROOT}/MC/config/PWGLF/pythia8/generator/resonances.cfg
config[1]=${O2DPG_ROOT}/MC/config/PWGLF/pythia8/generator/resonances.cfg

@BongHwi
Copy link
Contributor

BongHwi commented Apr 26, 2024

+async-label async-2022-pp-apass4,async-2022-pp-apass6-2023-PbPb-apass2,async-2023-pbpb-apass3,async-2023-pbpb-apass4

@github-actions github-actions bot added async-2022-pp-apass4 async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 labels Apr 26, 2024
@BongHwi
Copy link
Contributor

BongHwi commented Apr 26, 2024

Please update here after you test the updated script. @hkoley

@sawenzel
Copy link
Contributor

sawenzel commented May 6, 2024

@hkoley : I would be appreciated if you could provide a comment / textual description of what this PR is achieving. From the short commit message "fix trigger" it is not totally clear.

@sawenzel
Copy link
Contributor

It appears there was no further activity on this PR for some weeks? Is the PR still needed?

@hkoley hkoley closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BongHwi BongHwi BongHwi left review comments

@sawenzel sawenzel Awaiting requested review from sawenzel sawenzel is a code owner

@chiarazampolli chiarazampolli Awaiting requested review from chiarazampolli chiarazampolli is a code owner

@benedikt-voelkel benedikt-voelkel Awaiting requested review from benedikt-voelkel benedikt-voelkel is a code owner

Assignees
No one assigned
Labels
async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hkoley @BongHwi @sawenzel @benedikt-voelkel